Prevent Mediaquery from losing navigationMode value when removePadding() is called #101938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default constructor. This fixes the navigationMode value that being dropped when these methods were called, and should prevent similar issues from happening with other new fields in the future.
flutter-dashboard
bot
added
the
framework
ds84182
approved these changes
Apr 14, 2022
Contributor
ds84182
left a comment
ds84182
left a comment
There was a problem hiding this comment.
LGTM, we discussed this change and it'll prevent future issues when new fields are added to MediaQuery.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 19, 2022
…vePadding() is called (flutter/flutter#101938)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2022
…vePadding() is called (flutter/flutter#101938)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue where MediaQuery loses the value of the navigationMode field when removePadding(), removeViewPadding() or removeViewInsets() are called.
Switching those methods to use the copy constructor to prevent similar issues in the future.