Revert "Fix reverse cases for App Bar scrolled under behavior (#101460)" #101929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
XilaiZhang
approved these changes
Apr 14, 2022
Contributor
|
wasn't expecting this but seems like 'Linux framework_tests_libraries' test is failing? |
Contributor
Author
|
I see, fixing now. There were a lot conflicts with this revert |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
chunhtai
reviewed
Apr 15, 2022
| expect(tester.getSize(findAppBarMaterial()).height, kToolbarHeight); | ||
| }); | ||
|
|
||
| // Regression test for https://github.com/flutter/flutter/issues/80256 |
Contributor
There was a problem hiding this comment.
This accidentally reverted my test lol, it is ok though, since i am going to revert my change due to internal failure too....
just a heads up that you may run into test failure if you do a straight reland because this test will fail without my change
Contributor
Author
There was a problem hiding this comment.
Thanks @chunhtai sorry about that. There were a bunch of conflicts, this must have fallen through.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
godofredoc
added a commit
that referenced
this pull request
Apr 21, 2022
…" (#101929) (#102264) merging now since it blocks flutter roll for too long Co-authored-by: Kate Lovett <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2022
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c7d2935.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.