Skip to content

Migrate remaining files to super parameters #101919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Apr 14, 2022
Merged

Migrate remaining files to super parameters #101919

fluttergithubbot merged 1 commit into from
Apr 14, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Apr 14, 2022

Fixes #101455.

Part of #100575.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 14, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 14, 2022
@goderbauer
Copy link
Member Author

goderbauer commented Apr 14, 2022

Verified that google3 is no longer breaking with this migration applied.

christopherfujino
christopherfujino approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much for this.

@fluttergithubbot fluttergithubbot merged commit d5cbb36 into flutter:master Apr 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
d5cbb36 Migrate remaining files to super parameters (flutter/flutter#…
e389b5e 
…101919)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
d5cbb36 Migrate remaining files to super parameters (flutter/flutter#…
6e8887c 
…101919)
@goderbauer goderbauer deleted the remainingsuper branch April 14, 2022 19:36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
d5cbb36 Migrate remaining files to super parameters (flutter/flutter#…
87d454e 
…101919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate flutter_adapter.dart and flutter_test_adapter.dart to use super params

3 participants

@goderbauer @christopherfujino @fluttergithubbot