-
Notifications
You must be signed in to change notification settings - Fork 29.7k
SelectableText.rich: Fix TextSpan.style not merged into default text style
#101911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 👍
aba8add to
caf3159
Compare
Trying again. |
1410dd8 to
3cabf7f
Compare
|
cc: @HansMuller Another PR with failed Google testing, similar to the |
3cabf7f to
deeda49
Compare
deeda49 to
d9bc9f6
Compare
|
It looks like this broke a few Scubas by changing line height or something like that. Some text has moved vertically by <20px. It looks acceptable to me, so I'm setting the Google tests to passing and merging this. Sorry for the delay @TahaTesser! |
…efault text style (flutter/flutter#101911)
…efault text style (flutter/flutter#101911)
…ext style (flutter#101911) Properly merges the TextSpan.style of SelectableText.rich.
…efault text style (flutter/flutter#101911)
…efault text style (flutter/flutter#101911)
fixes #94042
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.