Add examples and troubleshooting comment for ClipRRect
#101907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: api docs
Member
|
@bleroux Looks like the doc check is not happy with this change. Can you take a look and fix that? |
bleroux
force-pushed
the
cliprrect_troubleshooting
branch
from
dbe8601 to
7a3e1f2
Compare
gspencergoog
requested changes
Apr 15, 2022
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Just some documentation nits here.
Contributor
There was a problem hiding this comment.
You might add a comment here about why this FittedBox is necessary.
Contributor
Author
There was a problem hiding this comment.
I added a comment and replaced FittedBox with a more meaningful BoxConstraints.tight
Contributor
There was a problem hiding this comment.
Suggested change
| /// This example shows various [ClipRRect] applied to containers. | |
| /// This example shows various [ClipRRect]s applied to containers. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// When [ClipRRect] is bigger than the child it contains, its rounded corners | |
| /// When a [ClipRRect] is bigger than the child it contains, its rounded corners |
Contributor
There was a problem hiding this comment.
Suggested change
| /// could be drawn not where expected. Make sure that [ClipRRect] and its child | |
| /// could be drawn in unexpected positions. Make sure that [ClipRRect] and its child |
Maybe describe in what way the location is surprising.
Contributor
There was a problem hiding this comment.
Suggested change
| /// ### Why my ClipRRect child doesn't have rounded corners? | |
| /// ### Why doesn't my [ClipRRect] child have rounded corners? |
bleroux
force-pushed
the
cliprrect_troubleshooting
branch
from
7a3e1f2 to
6d310ca
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two examples for
ClipRRect.First one to illustrate basic usage.
Second one to help troubleshooting round corners misplacement.
Related Issue
#93589
Tests
Adds tests for both examples
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.