Skip to content

Conversation

@AesSedai101
Copy link
Contributor

@AesSedai101 AesSedai101 commented Apr 14, 2022

My previous patch was reverted because of test failures in android_obfuscate_test.dart

This PR changes flutter build aar to make use of the maven-publish plugin, removing the maven plugin which as been previously deprecated and removed in Gradle 7.

See #101276 (original PR) and #101827 (the revert)

Fixes #101083 (again 😉 )

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Local test run

[android_obfuscate_test] Process terminated with exit code 0.
Task result:
{
  "success": true,
  "data": null,
  "detailFiles": [],
  "benchmarkScoreKeys": [],
  "reason": "success"
}


═══════════════╡ ••• Finished task "android_obfuscate_test" ••• ╞═══════════════



═════════════╡ ••• Flaky status for "android_obfuscate_test" ••• ╞══════════════

Test passed on first attempt.
flaky: false
[build_aar_module_test] Process terminated with exit code 0.
Task result:
{
  "success": true,
  "data": null,
  "detailFiles": [],
  "benchmarkScoreKeys": [],
  "reason": "success"
}


═══════════════╡ ••• Finished task "build_aar_module_test" ••• ╞════════════════



══════════════╡ ••• Flaky status for "build_aar_module_test" ••• ╞══════════════

Test passed on first attempt.
flaky: false

@AesSedai101 AesSedai101 requested a review from keyonghan as a code owner April 14, 2022 08:58
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 14, 2022
@AesSedai101 AesSedai101 changed the title Use the maven-publish plugin to publish AAR files. [WIP] Use the maven-publish plugin to publish AAR files. Apr 14, 2022
@AesSedai101 AesSedai101 changed the title [WIP] Use the maven-publish plugin to publish AAR files. Use the maven-publish plugin to publish AAR files. Apr 14, 2022
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmdmau
Copy link

ahmdmau commented Jan 30, 2023

Hi team, so for now flutter module support directly uploads to maven? and how to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build AARs with Gradle 7.0

5 participants