Skip to content

Fix Backbutton is not displayed when there is a endDrawer #101869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Apr 14, 2022
Merged

Fix Backbutton is not displayed when there is a endDrawer #101869

fluttergithubbot merged 2 commits into from
Apr 14, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Apr 13, 2022

fixes #80256

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. labels Apr 13, 2022
@dnfield
Copy link
Contributor

dnfield commented Apr 13, 2022

This seems fine to me, but it'd be good for @darrenaustin or @goderbauer to approve and make sure I'm not missing something that I'm no longer as familiar with here.

@chunhtai chunhtai requested a review from goderbauer April 13, 2022 23:57
goderbauer
goderbauer approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit e2d1206 into flutter:master Apr 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
e2d1206 Fix Backbutton is not displayed when there is a endDrawer (fl…
e45a76f 
…utter/flutter#101869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
e2d1206 Fix Backbutton is not displayed when there is a endDrawer (fl…
5229828 
…utter/flutter#101869)
chunhtai added a commit to chunhtai/flutter that referenced this pull request Apr 15, 2022
@chunhtai
Revert "Fix Backbutton is not displayed when there is a endDrawer (fl…
e2d2652 
…utter#101869)"

This reverts commit e2d1206.
chunhtai added a commit that referenced this pull request Apr 15, 2022
@chunhtai
Revert "Fix Backbutton is not displayed when there is a endDrawer (#1…
e16dc44 
…01869)" (#101998)

This reverts commit e2d1206.
godofredoc added a commit that referenced this pull request Apr 23, 2022
@godofredoc @chunhtai
Revert "Fix Backbutton is not displayed when there is a endDrawer (#1…
1a726f0 
…01869)" (#101998) (#102430)

This reverts commit e2d1206.

Co-authored-by: chunhtai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

@dnfield dnfield Awaiting requested review from dnfield

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BackButton is not displayed when there is a endDrawer

4 participants

@chunhtai @dnfield @goderbauer @fluttergithubbot