-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Increased StandardMethodCodec's WriteBuffer start capacity #101860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I'm not going to bother landing the benchmarks first. The savings are going to be similar to what we had with the other benchmarks. Although we'll probably benefit even more since method payloads are always going to be bigger. |
|
|
||
| import 'message_codec.dart'; | ||
|
|
||
| int _writeBufferStartCapacity = 64; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, thanks.
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit
|
This pull request is not suitable for automatic merging in its current state.
|
…01860) * Added standard method codec benchmark * increased writebuffer start size * added const
related: #101790
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.