Skip to content

Correct docs to refer to replacement render object #101858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Apr 13, 2022
Merged

Correct docs to refer to replacement render object #101858

fluttergithubbot merged 2 commits into from
Apr 13, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Apr 13, 2022

RenderUnconstrainedBox is deprecated, and will be removed in the near future. This trivial change updates the documentation to refer folks to the replacement API instead of the deprecated one.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 13, 2022
@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ documentation c: tech-debt Technical debt, code quality, testing, etc. labels Apr 13, 2022
goderbauer
goderbauer approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 65a8267 into flutter:master Apr 13, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2022
@engine-flutter-autoroll
65a8267 Correct docs to refer to replacement render object (flutter/f…
b385f8a 
…lutter#101858)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 13, 2022
@engine-flutter-autoroll
65a8267 Correct docs to refer to replacement render object (flutter/f…
4cf9088 
…lutter#101858)
werainkhatri
werainkhatri reviewed Apr 14, 2022
View reviewed changes
packages/flutter/lib/src/rendering/debug_overflow_indicator.dart
Comment on lines +88 to +89
/// * [RenderConstraintsTransformBox], [RenderConstraintsTransformBox], and
/// [RenderFlex] for examples of classes that use this indicator mixin.
Copy link
Member

@werainkhatri werainkhatri Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't these the same?

Suggested change
/// * [RenderConstraintsTransformBox], [RenderConstraintsTransformBox], and
/// [RenderFlex] for examples of classes that use this indicator mixin.
/// * [RenderConstraintsTransformBox], and [RenderFlex] for examples of classes
/// that use this indicator mixin.

Copy link
Contributor Author

@Piinks Piinks Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! See #101934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@werainkhatri werainkhatri werainkhatri left review comments

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Piinks @goderbauer @werainkhatri @fluttergithubbot