Skip to content

Test framework for executable files #101853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
Apr 14, 2022
Merged

Test framework for executable files #101853

fluttergithubbot merged 4 commits into from
Apr 14, 2022

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Apr 13, 2022

Fixes #101852

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Apr 13, 2022

Working on a test for this

@christopherfujino christopherfujino marked this pull request as ready for review April 13, 2022 20:46
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 13, 2022
@christopherfujino christopherfujino requested a review from Hixie April 13, 2022 20:46
@christopherfujino
Copy link
Contributor Author

christopherfujino commented Apr 13, 2022 •
edited
Loading

@Hixie WDYT about this test?

@christopherfujino christopherfujino changed the title remove execute permissions from .ci.yaml Test framework for executable files Apr 13, 2022
Hixie
Hixie approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 41b7389 into flutter:master Apr 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
41b7389 Test framework for executable files (flutter/flutter#101853)
76b73d2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
41b7389 Test framework for executable files (flutter/flutter#101853)
0842302
@christopherfujino christopherfujino deleted the no-execute-on-ci-yaml branch April 14, 2022 18:41
@keyonghan keyonghan mentioned this pull request Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.ci.yaml is executable on the framework

3 participants

@christopherfujino @Hixie @fluttergithubbot