Skip to content

Set the Clipboard more reliably in android semantics integration test. #101851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Apr 13, 2022
Merged

Set the Clipboard more reliably in android semantics integration test. #101851

fluttergithubbot merged 1 commit into from
Apr 13, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Apr 13, 2022

The flake happens when it try to store text into clipboard. This pr simplifies this process.

#98417

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 13, 2022
chunhtai
chunhtai commented Apr 13, 2022
View reviewed changes
dev/integration_tests/android_semantics_testing/test_driver/main_test.dart
// Ideally this should test the case where there is nothing on the
// clipboard as well, but there is no reliable way to clear the
// clipboard on Android devices.
final SerializableFinder normalTextField = find.descendant(
Copy link
Contributor Author

@chunhtai chunhtai Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really tell why this didn't work some of the time, it looks like running this setup with some state leaked from other test will cause it to fail.
I think it is ok to bypass this setup since this is not the focus of this test

jonahwilliams
jonahwilliams approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit adda8e9 into flutter:master Apr 13, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2022
@engine-flutter-autoroll
adda8e9 Set the Clipboard more reliably in android semantics integrat…
dc1b1f1 
…ion test. (flutter/flutter#101851)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 13, 2022
@engine-flutter-autoroll
adda8e9 Set the Clipboard more reliably in android semantics integrat…
c0de0d2 
…ion test. (flutter/flutter#101851)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chunhtai @jonahwilliams @goderbauer @fluttergithubbot