Skip to content

Update module_test_ios google_sign_in version #101729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Apr 12, 2022
Merged

Update module_test_ios google_sign_in version #101729

fluttergithubbot merged 1 commit into from
Apr 12, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 11, 2022

google_sign_in was hardcoded to 4.5.1, which did not contain the fix in 5.0.7 to mark arm simulators as unsupported. flutter/plugins#4208

Also remove deprecated device_info in favor of url_launcher.

Fixes #101722

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests platform-ios iOS applications specifically labels Apr 11, 2022
@jmagman jmagman self-assigned this Apr 11, 2022
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 11, 2022
@jmagman jmagman force-pushed the module-gsi-version branch from a08d301 to 4c60c50 Compare April 11, 2022 23:09
@jmagman jmagman force-pushed the module-gsi-version branch from 4c60c50 to b3f2571 Compare April 12, 2022 00:58
@jmagman jmagman mentioned this pull request Apr 12, 2022
Closed
christopherfujino
christopherfujino approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM. Would be nice to make this a little easier to update the next time, but I don't have any good ideas off the top of my head.

@fluttergithubbot fluttergithubbot merged commit b3d1f71 into flutter:master Apr 12, 2022
@jmagman jmagman deleted the module-gsi-version branch April 12, 2022 21:37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 12, 2022
@engine-flutter-autoroll
b3d1f71 Update module_test_ios google_sign_in version (flutter/flutte…
a086628 
…r#101729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2022
@engine-flutter-autoroll
b3d1f71 Update module_test_ios google_sign_in version (flutter/flutte…
4d07ada 
…r#101729)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mac_arm64_staging module_test_ios fails with Platform unit tests failed

4 participants

@jmagman @christopherfujino @hellohuanlin @fluttergithubbot