Skip to content

Enable unnecessary_import #101600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goderbauer merged 2 commits into from
Apr 8, 2022
Merged

Enable unnecessary_import #101600

goderbauer merged 2 commits into from
Apr 8, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Apr 8, 2022

@srawlins confirmed that this is reasonably stable now.

Fixes #74381.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 8, 2022
@goderbauer goderbauer requested a review from gspencergoog April 8, 2022 18:43
gspencergoog
gspencergoog approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@goderbauer goderbauer merged commit a014247 into flutter:master Apr 8, 2022
@goderbauer goderbauer deleted the unnecessary_import branch April 8, 2022 19:56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2022
@engine-flutter-autoroll
a014247 Enable unnecessary_import (flutter/flutter#101600)
0403c26
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 9, 2022
@engine-flutter-autoroll
a014247 Enable unnecessary_import (flutter/flutter#101600)
d062808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some flutter libraries have unnecessary import directives

2 participants

@goderbauer @gspencergoog