Test Flutter.xcframework directory ios-arm64_armv7 or ios-arm64 #101592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
a: tests
flutter-dashboard
bot
added
the
c: contributor-productivity
This was referenced Apr 8, 2022
| continue; | ||
| } | ||
| // ios-x86_64-simulator, ios-arm64_x86_64-simulator, ios-armv7_arm64 (Xcode 11), or ios-arm64_armv7 (Xcode 12). | ||
| // ios-x86_64-simulator, ios-arm64_x86_64-simulator, or ios-arm64. |
Contributor
There was a problem hiding this comment.
From looking at the code, it seems like _getIosArtifactPath() will automagically generate the correct path?
Member
Author
There was a problem hiding this comment.
Not sure what you mean, _getIosArtifactPath calls this method _getIosEngineArtifactPath
Used like this:
flutter/packages/flutter_tools/lib/src/build_system/targets/ios.dart
Lines 300 to 305 in e56c83a
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 9, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anticipation of the rename of these directories in #97342 in the engine, update these framework tests to handle either the directory
Flutter.xcframework/ios-arm64_armv7orFlutter.xcframework/ios-arm64depending on which one exists. This will allow the engine roll that introduces the directory name change to pass tests without framework changes.Also update a few comments to reference
ios-arm64instead ofios-arm64_armv7.See #85051 and #85642 for similar work when
ios-x86_64-simulatorbecameios-arm64_x86_64-simulator.Does not handle the codesigning script, to be addressed in a different PR (see also #85265)
flutter/dev/conductor/core/lib/src/codesign.dart
Line 188 in 3109073
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.