Linux and Windows right clicking text behavior #101588
Conversation
flutter-dashboard
bot
added
a: text input
justinmc
force-pushed
the
right-click-text
branch
from
b457c1f to
d9ddd26
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
f: cupertino
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
|
|
||
| expect(RendererBinding.instance.mouseTracker.debugDeviceActiveCursor(1), SystemMouseCursors.text); | ||
| expect(find.text('Copy'), findsOneWidget); | ||
| expect(find.text('Paste'), findsOneWidget); |
There was a problem hiding this comment.
Why does this change from Copy to Paste?
There was a problem hiding this comment.
Copy isn't shown if the selection is collapsed. Previously, right clicking would always select the underlying word, so copy would always be shown. Now it will be collapsed on Windows and Linux, and copy won't be there. But paste should always be there.
There was a problem hiding this comment.
Oh I get it. Thanks for the clarification!
|
The failed Google test seemed to have nothing to do with this PR (it was about the number of parameters in |
3 participants
Right clicking a text field should toggle the menu on Windows and Linux, whereas on Mac it selects the word and moves the menu.
Fixes #101587