Skip to content

Re-enable Gold post-submit fail state #101528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Apr 7, 2022
Merged

Re-enable Gold post-submit fail state #101528

fluttergithubbot merged 1 commit into from
Apr 7, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Apr 7, 2022

Gold post-submit testing has been stable for a while now. It should be safe to re-enable the post-submit fail state.
And issue was causing it to incorrectly close the tree previously, and it has been resolved.
Fixes #100304

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. team: flakes team-infra Owned by Infrastructure team c: tech-debt Technical debt, code quality, testing, etc. labels Apr 7, 2022
@Piinks Piinks requested a review from goderbauer April 7, 2022 18:28
goderbauer
goderbauer approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 7, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 324e6d9 into flutter:master Apr 7, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 7, 2022
@engine-flutter-autoroll
324e6d9 Re-enable Gold post-submit fail state (flutter/flutter#101528)
5aafbff
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2022
@engine-flutter-autoroll
324e6d9 Re-enable Gold post-submit fail state (flutter/flutter#101528)
3c3f41e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Post-submit failures in Gold are disabled

3 participants

@Piinks @fluttergithubbot @goderbauer