Fix reverse cases for App Bar scrolled under behavior #101460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
guidezpl
approved these changes
Apr 7, 2022
Contributor
Author
|
The google test failure here is unrelated to the change. Marking green manually. |
This was referenced Apr 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 7, 2022
XilaiZhang
added a commit
to XilaiZhang/flutter
that referenced
this pull request
Apr 14, 2022
…havior (flutter#101460)" This reverts commit c7d2935.
XilaiZhang
added a commit
to XilaiZhang/flutter
that referenced
this pull request
Apr 14, 2022
…havior (flutter#101460)" This reverts commit c7d2935.
XilaiZhang
added a commit
to XilaiZhang/flutter
that referenced
this pull request
Apr 14, 2022
Revert "Fix reverse cases for App Bar scrolled under behavior (flutter#101460)" This reverts commit c7d2935.
XilaiZhang
pushed a commit
that referenced
this pull request
Apr 14, 2022
…" (#101929) merging now since it blocks flutter roll for too long
godofredoc
added a commit
that referenced
this pull request
Apr 20, 2022
This reverts commit c7d2935.
godofredoc
added a commit
that referenced
this pull request
Apr 21, 2022
…" (#101929) (#102264) merging now since it blocks flutter roll for too long Co-authored-by: Kate Lovett <[email protected]>
This was referenced Apr 21, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101416
This fixes an issue where a reversed scroll view would not adhere to the scrolled under behavior when content extends under it until after a user scrolls. It changes the ScrollNotificationObserver to a ScrollMetricsNotificationObserver, as the ScrollMetricsNotification is what is required to get the initial metrics of the scroll view without having scrolled yet.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.