Skip to content

Partial revert of super params in tools #101436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goderbauer merged 1 commit into from
Apr 6, 2022
Merged

Partial revert of super params in tools #101436

goderbauer merged 1 commit into from
Apr 6, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Apr 6, 2022 •
edited
Loading

Google3 is failing on this:

google3:///[third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart:27](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart?l=27&ws=tap-prod-presubmit/179932707&snapshot=7):11: Error: The parameter 'ipv6' can't have a value of 'null' because of its type 'bool', but the implicit default value is 'null'.
Try adding either an explicit non-'null' default value or the 'required' modifier.
    super.ipv6,
          ^^^^
google3:///[third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart:28](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart?l=28&ws=tap-prod-presubmit/179932707&snapshot=7):11: Error: The parameter 'enableDds' can't have a value of 'null' because of its type 'bool', but the implicit default value is 'null'.
Try adding either an explicit non-'null' default value or the 'required' modifier.
    super.enableDds,
          ^^^^^^^^^
google3:///[third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart:29](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart?l=29&ws=tap-prod-presubmit/179932707&snapshot=7):11: Error: The parameter 'enableAuthCodes' can't have a value of 'null' because of its type 'bool', but the implicit default value is 'null'.
Try adding either an explicit non-'null' default value or the 'required' modifier.
    super.enableAuthCodes,
          ^^^^^^^^^^^^^^^
google3:///[third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart:27](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart?l=27&ws=tap-prod-presubmit/179932707&snapshot=7):11: Error: The parameter 'ipv6' can't have a value of 'null' because of its type 'bool', but the implicit default value is 'null'.
Try adding either an explicit non-'null' default value or the 'required' modifier.
    super.ipv6,
          ^^^^
google3:///[third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart:28](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart?l=28&ws=tap-prod-presubmit/179932707&snapshot=7):11: Error: The parameter 'enableDds' can't have a value of 'null' because of its type 'bool', but the implicit default value is 'null'.
Try adding either an explicit non-'null' default value or the 'required' modifier.
    super.enableDds,
          ^^^^^^^^^
google3:///[third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart:29](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart?l=29&ws=tap-prod-presubmit/179932707&snapshot=7):11: Error: The parameter 'enableAuthCodes' can't have a value of 'null' because of its type 'bool', but the implicit default value is 'null'.
Try adding either an explicit non-'null' default value or the 'required' modifier.
    super.enableAuthCodes,
          ^^^^^^^^^^^^^^^

@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 6, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 6, 2022
@goderbauer goderbauer merged commit 296221a into flutter:master Apr 6, 2022
@goderbauer goderbauer deleted the potentialfix branch April 6, 2022 18:04
@Hixie
Copy link
Contributor

Hixie commented Apr 6, 2022

test-exempt: code refactor with no semantic change

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2022
@engine-flutter-autoroll
296221a Partial revert of super params in tools (flutter/flutter#101436)
2a96227
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 6, 2022
@engine-flutter-autoroll
296221a Partial revert of super params in tools (flutter/flutter#101436)
dc5f663
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request Apr 6, 2022
@goderbauer
Partial revert of super params in tools (flutter#101436)
062a729
@goderbauer goderbauer mentioned this pull request Apr 6, 2022
Closed
CaseyHillers pushed a commit that referenced this pull request Apr 7, 2022
@goderbauer
[Cherrypick] Partial revert of super params in tools (#101436) (#101451)
548e885 
Co-authored-by: Michael Goderbauer <[email protected]>
CaseyHillers pushed a commit that referenced this pull request Apr 7, 2022
@goderbauer
[Cherrypick] Partial revert of super params in tools (#101436) (#101527)
d67e6ad 
Co-authored-by: Michael Goderbauer <[email protected]>
bernard-lee added a commit to bernard-lee/flutter that referenced this pull request Jun 29, 2022
@bernard-lee
Merge branch 'stable' of https://github.com/flutter/flutter into stable
bad536b 
* 'stable' of https://github.com/flutter/flutter: (1203 commits)
  'Update Engine revision to ffe7b86a1e5b5cb63c8385ae1adc759e372ee8f4 for stable release 3.0.3' (flutter#106431)
  [flutter_releases] Removing minor iOS version filter value from ci.yaml (flutter#105059) (flutter#105629)
  [flutter_releases] Flutter stable 3.0.2 Framework Cherrypicks (flutter#105528)
  [framework] ensure ink sparkle is disposed (flutter#104569) (flutter#105144)
  [CP] Fix Flutter doctor crash on Windows caused by bad UTF8 from vswhere.exe (flutter#105153)
  [tool][web] Use 'constructor' instead of 'public field declarations' in flutter.js (Safari 13) (flutter#105162)
  [flutter_releases] Cherrypicks for SliverReorderableList and Slider regressions (flutter#105141)
  'Update Engine revision to caaafc5604ee9172293eb84a381be6aadd660317 for stable release 3.0.1' (flutter#104213)
  [flutter_releases] Flutter stable 2.13.0 Framework Cherrypicks (flutter#103375)
  [flutter_releases] Flutter beta 2.13.0-0.4.pre Framework Cherrypicks (flutter#103101)
  Enforce cpu explicitly for Mac devicelab test beds (flutter#101871) (flutter#102685)
  [flutter_releases] Flutter beta 2.13.0-0.3.pre Framework Cherrypicks (flutter#102620)
  [flutter_releases] Upgrade dwds to 12.1.1 (flutter#101546)
  [flutter_releases] Flutter beta 2.13.0-0.2.pre Framework Cherrypicks (flutter#102193)
  [flutter_releases] Flutter beta 2.12.0-4.1.pre Framework Cherrypicks (flutter#101771)
  [flutter_releases] Cherrypick engine to c341645 (flutter#101608)
  Revert "Refactor `ToggleButtons` (remove `RawMaterialButton`) (flutter#99493)" (flutter#101538)
  [Cherrypick] Partial revert of super params in tools (flutter#101436) (flutter#101527)
  Roll Engine from e7e7ca1 to b48d65e (10 revisions) (flutter#101370)
  [flutter_tools] port bash script to use sysctl not uname on macOS (flutter#101308)
  ...
pieter-scholtz added a commit to pieter-scholtz/flutter that referenced this pull request Jul 7, 2022
@pieter-scholtz
Revert "[Cherrypick] Partial revert of super params in tools (flutter…
d5541a4 
…#101436) (flutter#101527)"

This reverts commit d67e6ad.
MohammedTarigg pushed a commit to MohammedTarigg/flutter that referenced this pull request Nov 21, 2025
@goderbauer @MohammedTarigg
[Cherrypick] Partial revert of super params in tools (flutter#101436) (…
3d79cfa 
…flutter#101451)

Co-authored-by: Michael Goderbauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer @Hixie @zanderso