Skip to content

Run update-packages #101398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jmagman wants to merge 1 commit into from
Closed

Run update-packages #101398

jmagman wants to merge 1 commit into from

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 6, 2022

Run flutter update-packages --force-upgrade

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 6, 2022
@jmagman jmagman self-assigned this Apr 6, 2022
@jmagman jmagman requested a review from Piinks as a code owner April 6, 2022 01:43
jmagman
jmagman commented Apr 6, 2022
View reviewed changes
packages/flutter_tools/pubspec.yaml
browser_launcher: 1.1.0
dds: 2.2.0
dwds: 12.1.0
dwds: 13.0.0
Copy link
Member Author

@jmagman jmagman Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dwds major bump
https://pub.dev/packages/dwds/changelog#1300

Copy link
Contributor

@annagrin annagrin Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Jen, this what I was trying to do now:) That might require changes in devfs_web.dart

@christopherfujino
Copy link
Contributor

christopherfujino commented Apr 6, 2022

I'm guessing test failures are legit?

@christopherfujino christopherfujino requested review from christopherfujino and removed request for Piinks April 6, 2022 16:13
@jmagman
Copy link
Member Author

jmagman commented Apr 6, 2022

I'm guessing test failures are legit?

Sure seems it. @elliette or @annagrin any idea what's up here with the web test timeouts from dwds: 12.1.0 to 13?

@annagrin
Copy link
Contributor

annagrin commented Apr 6, 2022

Sure seems it. @elliette or @annagrin any idea what's up here with the web test timeouts from dwds: 12.1.0 to 13?

I am going to sync to this branch and try it out. We have API change so some changes might be needed at the called of dsdw.start.

@annagrin annagrin mentioned this pull request Apr 6, 2022
Closed
@jmagman
Copy link
Member Author

jmagman commented Apr 7, 2022

Closing in favor of #101450

@jmagman jmagman closed this Apr 7, 2022
@jmagman jmagman deleted the update-packages branch May 4, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@annagrin annagrin annagrin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @christopherfujino @annagrin