Skip to content

Conversation

@gaaclarke
Copy link
Member

fixes #101313

When this feature was landed in flutter it created a 15% performance regression (#12058 (comment))

From my local testing with our build_bench.dart microbenchmarks I'm seeing similar results with debugProfileBuildsEnabled turned on. The parameters were added for a feature in the Dart observatory that no longer exists.

test-exempt: no added logic, removed logic for performance reasons

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 5, 2022
@gaaclarke gaaclarke force-pushed the remove-landmark-events branch from e5b70b4 to 814c154 Compare April 5, 2022 21:40
@gaaclarke gaaclarke marked this pull request as ready for review April 5, 2022 21:41
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gaaclarke gaaclarke requested a review from dnfield April 5, 2022 21:41
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM if it LGT @kenzieschmoll

@dnfield dnfield requested a review from kenzieschmoll April 5, 2022 21:52
@dnfield
Copy link
Contributor

dnfield commented Apr 5, 2022

I'm assuming this is fine to remove based on my read of devtools - if that's wrong we should definitely add some kind of test that would fail in this repository for it.

@goderbauer
Copy link
Member

From triage: Even though the "Google testing" check didn't seem to update, it looks like this is causing some legit failures in google3 (see "details" link of the check):

ERROR: mobile/flutter/testing/integration_test/perf/lib/extension.dart

201: arguments: timelineArgumentsIndicatingLandmarkEvent, Undefined name. #undefined_identifier

@gaaclarke Can you take a look and maybe create a g3fix?

@dnfield
Copy link
Contributor

dnfield commented Apr 6, 2022

/cc @jiahaog fyi

@gaaclarke
Copy link
Member Author

gaaclarke commented Apr 6, 2022

We could potentially keep that field around but make it nullable and giving it a "deprecated" annotation. I'd rather just delete it since people shouldn't be using it. It was leaking dart implementation details all the way into the framework API so it was a bad idea to begin with. Forward fix put up for review.

@jiahaog
Copy link
Member

jiahaog commented Apr 7, 2022

Thanks, the forward fix looks good

@gaaclarke
Copy link
Member Author

The forward fix for google has landed.

@kenzieschmoll
Copy link
Member

There may be merge conflicts from #101602.

@CaseyHillers
Copy link
Contributor

Sorry about Google Testing being blocked! Feel free to submit this as is, or if you want to verify this with google3 presubmit you can push an empty commit.

@gaaclarke gaaclarke force-pushed the remove-landmark-events branch from 97aac48 to b50267c Compare April 12, 2022 21:05
@fluttergithubbot fluttergithubbot merged commit 9124287 into flutter:master Apr 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the Timeline performance

7 participants