Skip to content

Add alignment parameter for persistentFooterButtons #101297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Apr 15, 2022
Merged

Add alignment parameter for persistentFooterButtons #101297

fluttergithubbot merged 1 commit into from
Apr 15, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Apr 4, 2022

fixes #46061

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 4, 2022
@HansMuller HansMuller requested a review from dkwingsmt April 8, 2022 21:58
@TahaTesser TahaTesser changed the title Add aligment parameter for persistentFooterButtons Add alignment parameter for persistentFooterButtons Apr 9, 2022
dkwingsmt
dkwingsmt approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 638aae7 into flutter:master Apr 15, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 16, 2022
@engine-flutter-autoroll
638aae7 Add alignment parameter for persistentFooterButtons (flutte…
0ae6a83 
…r/flutter#101297)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
638aae7 Add alignment parameter for persistentFooterButtons (flutte…
5cfb1a8 
…r/flutter#101297)
@TahaTesser TahaTesser deleted the scaffold_persistent branch September 14, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

persistentFooterButtons should not wrap in a ButtonBar class which is right aligned

3 participants

@TahaTesser @dkwingsmt @fluttergithubbot