Skip to content

Conversation

@DetachHead
Copy link
Contributor

fixes #101252

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 3, 2022
@DetachHead
Copy link
Contributor Author

seems i don't have access to the ci so i can't see why it's failing

image

@christopherfujino
Copy link
Contributor

@DetachHead looks like you have a legitimate test failure:

00:26 +55 ~3 -1: test/analyze_sample_code_test.dart: Analyzes dart:ui code [E]                                                                                                                         
  Expected: contains all of [
              'In sample starting at dev/bots/test/analyze-sample-code-test-dart-ui/ui.dart:15:class MyStatelessWidget extends StatelessWidget {',
              '>>> error: Missing concrete implementation of \'StatelessWidget.build\' (non_abstract_class_inherits_abstract_member)',
              'In sample starting at dev/bots/test/analyze-sample-code-test-dart-ui/ui.dart:15:class MyStringBuffer {',
              '>>> error: Classes can\'t be declared inside other classes (class_in_class)'
            ]
    Actual: [
              'Unhandled exception:',
              'Cannot analyze dartdocs; unexpected error output:',
              '[Because analyze_sample_code depends on flutter_test from sdk which doesn\'t exist (the Flutter SDK is not available), version solving failed., , Flutter users should run `flutter pub get` instead of `dart pub get`., 10 issues found. (ran in 3.5s)]',
              '#0      SampleChecker._runAnalyzer (file:///opt/s/w/ir/x/w/flutter/dev/bots/analyze_sample_code.dart:817:7)',
              '#1      SampleChecker._analyze (file:///opt/s/w/ir/x/w/flutter/dev/bots/analyze_sample_code.dart:838:20)',
              '#2      SampleChecker.checkSamples (file:///opt/s/w/ir/x/w/flutter/dev/bots/analyze_sample_code.dart:402:24)',
              '<asynchronous suspension>',
              '#3      main (file:///opt/s/w/ir/x/w/flutter/dev/bots/analyze_sample_code.dart:147:18)',
              '<asynchronous suspension>',
              ''
            ]
     Which: has no match for 'In sample starting at dev/bots/test/analyze-sample-code-test-dart-ui/ui.dart:15:class MyStatelessWidget extends StatelessWidget {' at index 0 along with 3 other unmatched
  
  package:test_api                         expect
  test/analyze_sample_code_test.dart 59:5  main.<fn>

https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20framework_tests_misc/17701/overview

@DetachHead
Copy link
Contributor Author

@christopherfujino no idea what couldve caused that but it looks like all the tests are passing now after i applied @goderbauer's suggestion

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit ba89942 into flutter:master Apr 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prefer_final_parameters lint error in generated_plugin_registrant.dart

5 participants