-
Notifications
You must be signed in to change notification settings - Fork 29.7k
ignore prefer_final_parameters in generated_plugin_registrant template
#101253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@DetachHead looks like you have a legitimate test failure: |
|
@christopherfujino no idea what couldve caused that but it looks like all the tests are passing now after i applied @goderbauer's suggestion |
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jasguerrero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

fixes #101252
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.