Skip to content

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Apr 1, 2022

Spring cleaning

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 1, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the clean-up!

@goderbauer
Copy link
Member

I thought we have a check for this, though, that stops code with trailing spaces from getting submitted?

@goderbauer
Copy link
Member

Oh, does that check maybe only trigger on changed lines and not existing violations?

@Hixie
Copy link
Contributor

Hixie commented Apr 1, 2022

Or maybe it only checks .dart files?

Let's fix the test, then we don't need a test exemption here. :-)

@guidezpl
Copy link
Member Author

guidezpl commented Apr 4, 2022

It does check all files, but only modified lines. My guess is the cases this PR fixes predate the test. So fine to submit without modifying a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants