Skip to content

Conversation

@wangying3426
Copy link
Contributor

@wangying3426 wangying3426 commented Mar 31, 2022

Fix #101102

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 31, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@TahaTesser
Copy link
Member

TahaTesser commented Mar 31, 2022

Please add all properties and this PR requires a test.

@wangying3426
Copy link
Contributor Author

Please add all properties and this PR requires a test.

Fixed.

@wangying3426 wangying3426 requested a review from goderbauer April 2, 2022 01:44
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangying3426
Copy link
Contributor Author

wangying3426 commented Apr 4, 2022

Please add all properties and this PR requires a test.

cc @TahaTesser Could you have a look at this again? It needs two flutter members to review.

@goderbauer
Copy link
Member

@Piinks Could you do a secondary review?

Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser
Copy link
Member

@wangying3426
Can you rebase or add an empty commit so Google Testing passes to get this merged?

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@wangying3426
Copy link
Contributor Author

wangying3426 commented Apr 11, 2022

@wangying3426 Can you rebase or add an empty commit so Google Testing passes to get this merged?

There seem to be some problem for Google testing, it has failed several times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debug properties of BackdropFilterLayer missed

6 participants