Skip to content

migrate generated i18n code to super params #101065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 30, 2022
Merged

migrate generated i18n code to super params #101065

fluttergithubbot merged 1 commit into from
Mar 30, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Mar 30, 2022

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 30, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 30, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer goderbauer requested a review from gspencergoog March 30, 2022 18:18
@goderbauer goderbauer mentioned this pull request Mar 30, 2022
Closed
16 tasks
@Hixie
Copy link
Contributor

Hixie commented Mar 30, 2022

test-exempt: code refactor with no semantic change

gspencergoog
gspencergoog approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

dev/tools/localization/gen_cupertino_localizations.dart
singleDigitSecondFormat: singleDigitSecondFormat,
decimalFormat: decimalFormat,
);''';
super.localeName = '$localeName',
Copy link
Contributor

@gspencergoog gspencergoog Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much clean!

@fluttergithubbot fluttergithubbot merged commit d021509 into flutter:master Mar 30, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
5a040c6 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
a2068cd 
…101065)
@goderbauer goderbauer deleted the super_params_loc branch March 31, 2022 22:30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
5f6e2a9 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
ef6b414 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
d04b772 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
115c30e 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
2fc21bb 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
5e0e072 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
e61f2c9 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
fd4ca83 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
66a5950 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
20fa992 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 2, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
d3c9dc8 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 2, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
920d1ff 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
2495188 
…101065)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
ecac3c3 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
ea15e05 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
9121416 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
3f0c7e2 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
b1dacb6 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
ef78e63 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
f4036a8 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
5058a4e 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
7075d45 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
4748161 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
3614d34 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
43f7cff 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
58d171c 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
df9b353 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
3146b01 
…101065)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
d021509 migrate generated i18n code to super params (flutter/flutter#…
785149a 
…101065)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@goderbauer @Hixie @gspencergoog @fluttergithubbot