Skip to content

Revert "Reland: "Use texture layer when displaying an Android view" " #100950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GaryQian merged 1 commit into from
Mar 29, 2022
Merged

Revert "Reland: "Use texture layer when displaying an Android view" " #100950

GaryQian merged 1 commit into from
Mar 29, 2022

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Mar 29, 2022

Reverts #100934

It looks like android hybrid_android_views_integration_test is failing consistently after this change.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 29, 2022
@zanderso zanderso requested review from blasten and cyanglaz March 29, 2022 06:00
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 29, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.
  • The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 29, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@GaryQian GaryQian merged commit 37d619d into master Mar 29, 2022
@GaryQian GaryQian deleted the revert-100934-reland_tx_pv branch March 29, 2022 15:27
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
37d619d Revert "Reland: "Use texture layer when displaying an Android…
a4fe1c5 
… view" (#100934)" (flutter/flutter#100950)
@blasten
Copy link

blasten commented Mar 29, 2022

@GaryQian I thought this test was running in presubmits. is that no longer the case?

blasten pushed a commit to blasten/flutter that referenced this pull request Mar 29, 2022
Revert "Revert "Reland: "Use texture layer when displaying an Android…
fb7f1c4 
… view" (flutter#100934)" (flutter#100950)"

This reverts commit 37d619d.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
37d619d Revert "Reland: "Use texture layer when displaying an Android…
c4779db 
… view" (#100934)" (flutter/flutter#100950)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blasten blasten Awaiting requested review from blasten

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

1 more reviewer

@GaryQian GaryQian GaryQian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zanderso @fluttergithubbot @blasten @GaryQian