Skip to content

Prepare framework for use_super_parameters #100905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goderbauer merged 1 commit into from
Apr 14, 2022
Merged

Prepare framework for use_super_parameters #100905

goderbauer merged 1 commit into from
Apr 14, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Mar 28, 2022 •
edited
Loading

BLOCKED on dart-lang/sdk#48769. Fixed.
BLOCKED ON dart-lang/sdk#48727. Fixed.
BLOCKED ON dart-lang/sdk#48719. Fixed.
BLOCKED ON dart-lang/sdk#48697. Fixed.

#100575

Once all code in the repo has been migrated, we can turn on the use_super_parameters lint.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 28, 2022
@goderbauer goderbauer mentioned this pull request Mar 28, 2022
Closed
16 tasks
@goderbauer goderbauer force-pushed the super_framework branch 3 times, most recently from eefffac to 8917337 Compare March 29, 2022 22:28
goderbauer
goderbauer commented Mar 29, 2022
View reviewed changes
@goderbauer goderbauer changed the title Prepare framework for use_super_parameters [BLOCKED] Prepare framework for use_super_parameters Mar 30, 2022
@goderbauer goderbauer force-pushed the super_framework branch 7 times, most recently from 8378ec1 to db89a01 Compare April 1, 2022 17:10
This was referenced Apr 1, 2022
Merged
Merged
@goderbauer goderbauer requested a review from gspencergoog April 1, 2022 23:15
gspencergoog
gspencergoog approved these changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

RSLGTM: GitHub can't handle this many files in a review, but I assume that they're all basically the same.

@goderbauer goderbauer force-pushed the super_framework branch 6 times, most recently from 24e09e1 to a9f2e96 Compare April 8, 2022 08:21
@goderbauer goderbauer changed the title [BLOCKED] Prepare framework for use_super_parameters Prepare framework for use_super_parameters Apr 8, 2022
@goderbauer goderbauer changed the title Prepare framework for use_super_parameters [Blocked] Prepare framework for use_super_parameters Apr 8, 2022
@goderbauer goderbauer force-pushed the super_framework branch 7 times, most recently from 695df00 to e426294 Compare April 13, 2022 20:30
@goderbauer goderbauer changed the title [Blocked] Prepare framework for use_super_parameters Prepare framework for use_super_parameters Apr 13, 2022
@goderbauer
Copy link
Member Author

goderbauer commented Apr 14, 2022

"Google testing" has some kind of infra problem and it's not able to run the tests. I am going to merge this and watch for post-submit failures.

@goderbauer goderbauer merged commit 51bcdb9 into flutter:master Apr 14, 2022
@goderbauer goderbauer deleted the super_framework branch April 14, 2022 05:38
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
51bcdb9 super parameters for framework (flutter/flutter#100905)
fcce838
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
51bcdb9 super parameters for framework (flutter/flutter#100905)
9baed83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goderbauer @gspencergoog