Skip to content

The sample code used within the comments in textContaining is wrong #100860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goderbauer merged 3 commits into from
Apr 20, 2022
Merged

The sample code used within the comments in textContaining is wrong #100860

goderbauer merged 3 commits into from
Apr 20, 2022

Conversation

@8rine23
Copy link
Contributor

@8rine23 8rine23 commented Mar 27, 2022

fixes #100859

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Mar 27, 2022
HansMuller
HansMuller reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an additional problem here. The textContaining method doesn't have a findRichText parameter.

@8rine23
Copy link
Contributor Author

8rine23 commented Mar 29, 2022 •
edited
Loading

@HansMuller
Thanks for commenting on this pull-request.
I would like to address the problem, but I don't know how to fix the documentation.
Could you please tell me how to fix the textContaining document?

@HansMuller
Copy link
Contributor

HansMuller commented Mar 29, 2022

It looks like the example is wrong. The text finder has a findRichText parameter, the textContaining finder does not.

@goderbauer
Copy link
Member

goderbauer commented Apr 13, 2022

@HansMuller The textContaining matcher does have a findRichText property on master: https://master-api.flutter.dev/flutter/flutter_test/CommonFinders/textContaining.html. With that, this change looks fine to me.

goderbauer
goderbauer approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HansMuller
HansMuller approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer merged commit 9313fb8 into flutter:master Apr 20, 2022
jen801
jen801 reviewed Apr 20, 2022
View reviewed changes
Copy link

@jen801 jen801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/flutter_test/lib/src/finders.dart

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
9313fb8 The sample code used within the comments in textContaining is…
3390702 
… wrong (flutter/flutter#100860)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
9313fb8 The sample code used within the comments in textContaining is…
7f58eee 
… wrong (flutter/flutter#100860)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
9313fb8 The sample code used within the comments in textContaining is…
003e664 
… wrong (flutter/flutter#100860)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@8rine23 @egramond
The sample code used within the comments in textContaining is wrong (f…
07225b7 
…lutter#100860)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+2 more reviewers

@jen801 jen801 jen801 left review comments

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The sample code used within the comments in textContaining is wrong

4 participants

@8rine23 @HansMuller @goderbauer @jen801