Skip to content

RawKeyboardMacos accepts a new field "specifiedLogicalKey" #100803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
Apr 14, 2022
Merged

RawKeyboardMacos accepts a new field "specifiedLogicalKey" #100803

fluttergithubbot merged 5 commits into from
Apr 14, 2022

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Mar 25, 2022 •
edited
Loading

This PR adds a new field specifiedLogicalKey to RawKeyboardMacos and its channel message. This field is used in conjunction to flutter/engine#32152, which detects the keyboard layout as a whole to derive key mapping in a way that can't be calculated on a per-key basis.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 25, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 25, 2022
@dkwingsmt dkwingsmt mentioned this pull request Mar 25, 2022
Merged
8 tasks
@dkwingsmt dkwingsmt changed the title RawKeyboardMacos accepts a new field "overrideLogicalKey" RawKeyboardMacos accepts a new field "specifiedLogicalKey" Mar 25, 2022
@dkwingsmt dkwingsmt requested a review from gspencergoog March 25, 2022 23:31
gspencergoog
gspencergoog approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 4, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 4, 2022

This pull request is not suitable for automatic merging in its current state.

@dkwingsmt dkwingsmt added a: text input Entering text in a text field or keyboard related problems waiting for tree to go green platform-mac Building on or for macOS specifically a: desktop Running on desktop labels Apr 14, 2022
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 14, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit c5e3e1c into master Apr 14, 2022
@fluttergithubbot fluttergithubbot deleted the detect-layout branch April 14, 2022 18:24
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
c5e3e1c RawKeyboardMacos accepts a new field "specifiedLogicalKey" (f…
f33f1d5 
…lutter/flutter#100803)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
c5e3e1c RawKeyboardMacos accepts a new field "specifiedLogicalKey" (f…
be957e1 
…lutter/flutter#100803)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
c5e3e1c RawKeyboardMacos accepts a new field "specifiedLogicalKey" (f…
c394f50 
…lutter/flutter#100803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. platform-mac Building on or for macOS specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dkwingsmt @fluttergithubbot @gspencergoog