Skip to content

Benchmark cannot run in Android12 phone #100761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Apr 27, 2022
Merged

Benchmark cannot run in Android12 phone #100761

fluttergithubbot merged 1 commit into from
Apr 27, 2022

Conversation

@JsouLiang
Copy link
Contributor

@JsouLiang JsouLiang commented Mar 25, 2022

connect issue #100760

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 25, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 25, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso zanderso requested a review from blasten March 30, 2022 04:01
@dnfield
Copy link
Contributor

dnfield commented Mar 30, 2022

The latest templates have this but no one updated this one yet. Thanks!

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 30, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@JsouLiang
Copy link
Contributor Author

JsouLiang commented Mar 30, 2022

cc @blasten

eggfly
eggfly approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@eggfly eggfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JsouLiang JsouLiang force-pushed the benchmark-cannot-run-in-android-12 branch from 22a4453 to 8256b90 Compare April 22, 2022 02:39
@fluttergithubbot fluttergithubbot merged commit 3d14882 into flutter:master Apr 27, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
3bce8d5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
5d9ea00
zanderso added a commit that referenced this pull request Apr 27, 2022
@zanderso
Revert "Benchmark cannot run in Android12 phone (#100761)"
5056c4e 
This reverts commit 3d14882.
@zanderso zanderso mentioned this pull request Apr 27, 2022
Merged
zanderso added a commit that referenced this pull request Apr 27, 2022
@zanderso
Revert "Benchmark cannot run in Android12 phone (#100761)" (#102649)
9876b0d 
This reverts commit 3d14882.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
4b8e5c5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
d6829eb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
38903cb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
e4ae489
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
0ed2f27
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
08bcb51
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
af46b26
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
bc3fc29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
1f059d0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
df999d6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
1564edc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
990f67b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
b824edf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
0d0eab8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
21969ba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
408c5b5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
3d14882 Benchmark cannot run in Android12 phone (flutter/flutter#100761)
60e8f49
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@JsouLiang @egramond
Benchmark cannot run in Android12 phone (flutter#100761)
734264e
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@zanderso @egramond
Revert "Benchmark cannot run in Android12 phone (flutter#100761)" (fl…
b4b217b 
…utter#102649)

This reverts commit 3d14882.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eggfly eggfly eggfly approved these changes

@zanderso zanderso Awaiting requested review from zanderso

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

@blasten blasten Awaiting requested review from blasten

+1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JsouLiang @dnfield @fluttergithubbot @eggfly