Skip to content

[flutter_tools] Fix VersionUpstreamValidator to respect FLUTTER_GIT_URL #100605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 26, 2022
Merged

[flutter_tools] Fix VersionUpstreamValidator to respect FLUTTER_GIT_URL #100605

fluttergithubbot merged 1 commit into from
Mar 26, 2022

Conversation

@royarg02
Copy link
Contributor

@royarg02 royarg02 commented Mar 23, 2022 •
edited
Loading

Fixes VersionUpstreamValidator to always respect FLUTTER_GIT_URL for checking whether the current channel tracks a standard remote.

Fixes #100604.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 23, 2022
@royarg02 royarg02 force-pushed the fix_flutterGit_upstreamvalidator branch from e5bed73 to 33fb371 Compare March 23, 2022 08:12
@royarg02 royarg02 force-pushed the fix_flutterGit_upstreamvalidator branch from 33fb371 to de9e028 Compare March 23, 2022 12:21
@christopherfujino
Copy link
Contributor

christopherfujino commented Mar 23, 2022

So, to clarify, this behavior of toolExiting if the user sets FLUTTER_GIT_URL and their current branch is not already tracking is what we already had (because you implemented) before #97202, correct?

@royarg02
Copy link
Contributor Author

royarg02 commented Mar 23, 2022 •
edited
Loading

So, to clarify, this behavior of toolExiting if the user sets FLUTTER_GIT_URL and their current branch is not already tracking is what we already had (because you implemented) before #97202, correct?

That would be correct, yes(for the upgrade flow, at least).

christopherfujino
christopherfujino approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christopherfujino
Copy link
Contributor

christopherfujino commented Mar 23, 2022

@Jasguerrero could you take a look at this?

Jasguerrero
Jasguerrero approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit e7ab846 into flutter:master Mar 26, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2022
@engine-flutter-autoroll
e7ab846 [flutter_tools] Fix VersionUpstreamValidator to respect FLUTT…
3dbf87c 
…ER_GIT_URL (flutter/flutter#100605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e7ab846 [flutter_tools] Fix VersionUpstreamValidator to respect FLUTT…
a89dcc8 
…ER_GIT_URL (flutter/flutter#100605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e7ab846 [flutter_tools] Fix VersionUpstreamValidator to respect FLUTT…
6524a6e 
…ER_GIT_URL (flutter/flutter#100605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e7ab846 [flutter_tools] Fix VersionUpstreamValidator to respect FLUTT…
0c0156a 
…ER_GIT_URL (flutter/flutter#100605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e7ab846 [flutter_tools] Fix VersionUpstreamValidator to respect FLUTT…
edf0752 
…ER_GIT_URL (flutter/flutter#100605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e7ab846 [flutter_tools] Fix VersionUpstreamValidator to respect FLUTT…
f5e2655 
…ER_GIT_URL (flutter/flutter#100605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e7ab846 [flutter_tools] Fix VersionUpstreamValidator to respect FLUTT…
6d5f6a4 
…ER_GIT_URL (flutter/flutter#100605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e7ab846 [flutter_tools] Fix VersionUpstreamValidator to respect FLUTT…
056ee80 
…ER_GIT_URL (flutter/flutter#100605)
@royarg02 royarg02 mentioned this pull request May 2, 2022
Merged
8 tasks
@royarg02 royarg02 deleted the fix_flutterGit_upstreamvalidator branch May 7, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@Jasguerrero Jasguerrero Jasguerrero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tool] VersionUpstreamValidator ignores FLUTTER_GIT_URL if upstream repository is standard

4 participants

@royarg02 @christopherfujino @Jasguerrero @fluttergithubbot