Repository navigation
Roll Engine from c176d6fb06cd to 4fbff7a5114a (2 revisions) - #100587
Merged
Conversation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
deleted the
flutter-engine-flutter-autoroll-5793dc8c-162d-4c29-852b-18b9339935ec-1647986283
branch
March 29, 2022 22:50
This was referenced Oct 27, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 27, 2026
…a_table_test, floating_action_button_test, text_field_cursor_test (#13460) Removes web skips from three `material_ui` test files whose tests now pass on Chrome under both web renderers used in CI (CanvasKit/dart2js and Skwasm/dart2wasm). Keeping the skips hides web regressions in these widgets. - `data_table_test.dart`: removes the file-level `@TestOn('!chrome')`. The column/cell padding finders now use `'${6.0}'` instead of `'6.0'`, so they match the text on dart2js (JS prints doubles with no fractional part as `6`, not `6.0`). Only the M3 `InkSparkle` press test stays skipped on web (flutter/flutter#100587). - `floating_action_button_test.dart`: removes the file-level `@TestOn('!chrome')`, which turns 43 tests back on for web. The two ink splash clipping tests stay skipped on web (flutter/flutter#20483). - `text_field_cursor_test.dart`: removes the file-level `@TestOn('!chrome')`. All 9 cursor animation, timing, and platform radius variants pass on web. Verified locally with `flutter test --platform chrome` and `flutter test --platform chrome --wasm` for each file. Part of flutter/flutter#100587 Part of flutter/flutter#20483 ## Pre-Review Checklist This PR only changes tests, so it is exempt from version/CHANGELOG updates and from the new-test requirement. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter-team-archive/engine@c176d6f...4fbff7a
2022-03-22 [email protected] Roll Skia from 6424dd02a868 to c29e37ad4c68 (1 revision) (flutter-team-archive/engine#32193)
2022-03-22 [email protected] Roll Skia from f8df8d88969d to 6424dd02a868 (8 revisions) (flutter-team-archive/engine#32190)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md