Relands "Starts using the --source flag to compile the dart registrant. (#98046)" #100572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
flutter-dashboard
bot
added
framework
|
Gold has detected about 1 new digest(s) on patchset 2. |
gaaclarke
force-pushed
the
reland-fdcd14464cea6505be3eb9efdcdad1c39d7aaa64
branch
2 times, most recently
from
9104fb9 to
10fd6ed
Compare
goderbauer
changed the title
gaaclarke
force-pushed
the
reland-fdcd14464cea6505be3eb9efdcdad1c39d7aaa64
branch
from
10fd6ed to
91b9dfd
Compare
gaaclarke
force-pushed
the
reland-fdcd14464cea6505be3eb9efdcdad1c39d7aaa64
branch
2 times, most recently
from
da222c6 to
921efbb
Compare
the engine can execute it.
gaaclarke
force-pushed
the
reland-fdcd14464cea6505be3eb9efdcdad1c39d7aaa64
branch
from
921efbb to
bb82938
Compare
blasten
reviewed
Mar 28, 2022
Comment on lines
+399
to
+401
| '.dart_tools/flutter_build/dart_plugin_registrant.dart', | ||
| '--source', | ||
| 'package:flutter/src/dart_plugin_registrant.dart', |
There was a problem hiding this comment.
is .dart_tools/flutter_build/dart_plugin_registrant.dart content different than package:flutter/src/dart_plugin_registrant.dart? If different, is it possible to assign a different name?
Member
Author
There was a problem hiding this comment.
Yep, the contents are different. .dart_tools/flutter_build/dart_plugin_registrant.dart is where the generated code is. package:flutter/src/dart_plugin_registrant.dart points to where the generated code is.
We could change the name of .dart_tools/flutter_build/dart_plugin_registrant.dart easily. Changing package:flutter/src/dart_plugin_registrant.dart would require a change in the engine since that is where it is looking for it.
blasten
approved these changes
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
…egistrant. (#98046)" (flutter/flutter#100572)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
…egistrant. (#98046)" (flutter/flutter#100572)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
…egistrant. (#98046)" (flutter/flutter#100572)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
…egistrant. (#98046)" (flutter/flutter#100572)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
…egistrant. (#98046)" (flutter/flutter#100572)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
…egistrant. (#98046)" (flutter/flutter#100572)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 4, 2022
…egistrant. (#98046)" (flutter/flutter#100572)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lands the original PR in the first commit. The subsequent commits do the fix to reland this. What's different now is that we have a file in the framework that will be compiled to point to the location of the dart plugin registrant. That is loaded and executed in the engine.
This allows us to directly look for the dart plugin registrant instead of hunting for it, thus eliminating the cost of the linear search which caused this to be reverted in the first place.
Engine PR: flutter/engine#32189
Relands: #98046
The revert: #100493
Fixes: #98591
Fixes: #91841
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.