Repository navigation
Framework support for checkerboardOffscreenLayers - #10054
Merged
Merged
Conversation
Contributor
Author
Contributor
|
|
Hixie
reviewed
May 12, 2017
Contributor
There was a problem hiding this comment.
Can you include a paragraph that discusses how this differs from checkerboardRasterCacheImages?
Hixie
reviewed
May 12, 2017
Contributor
There was a problem hiding this comment.
Please include all the information from the render layer here (also on checkerboardRasterCacheImages while we're at it).
Hixie
reviewed
May 12, 2017
Contributor
There was a problem hiding this comment.
this class should also have the same documentation as the other classes.
Contributor
|
Is this testable? |
jason-simmons
force-pushed
the
save_layer_checker
branch
from
May 12, 2017 21:23
aee4ca9 to
5b88671
Compare
jason-simmons
force-pushed
the
save_layer_checker
branch
from
May 12, 2017 21:31
5b88671 to
8049ea9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9473