Skip to content

[RenderAnimatedSize] Resume interrupted resizing animation on attach #100519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Mar 22, 2022
Merged

[RenderAnimatedSize] Resume interrupted resizing animation on attach #100519

fluttergithubbot merged 2 commits into from
Mar 22, 2022

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Mar 22, 2022

Currently a RenderAnimatedSize will lose its running animation and is
not marked dirty when it needs resizing and is re-attached to the render
object tree.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@LongCatIsLooong
[RenderAnimatedSize] Resume interrupted resizing animation on attach
b93055e 
Currently a `RenderAnimatedSize` will lose its running animation and is
not marked dirty when it needs resizing and is re-attached to the render
object tree.
@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Mar 22, 2022
goderbauer
goderbauer approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit dc331d3 into flutter:master Mar 22, 2022
@LongCatIsLooong LongCatIsLooong deleted the resume-animatedsize-animation-on-reattach branch March 22, 2022 20:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2022
@engine-flutter-autoroll
dc331d3 [RenderAnimatedSize] Resume interrupted resizing animation on…
b11c77b 
… attach (flutter/flutter#100519)
@LongCatIsLooong LongCatIsLooong mentioned this pull request Mar 22, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2022
@engine-flutter-autoroll
dc331d3 [RenderAnimatedSize] Resume interrupted resizing animation on…
a888a13 
… attach (flutter/flutter#100519)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
dc331d3 [RenderAnimatedSize] Resume interrupted resizing animation on…
6fe749e 
… attach (flutter/flutter#100519)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
dc331d3 [RenderAnimatedSize] Resume interrupted resizing animation on…
cb942b1 
… attach (flutter/flutter#100519)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
dc331d3 [RenderAnimatedSize] Resume interrupted resizing animation on…
00e8624 
… attach (flutter/flutter#100519)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
dc331d3 [RenderAnimatedSize] Resume interrupted resizing animation on…
7690fd8 
… attach (flutter/flutter#100519)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
dc331d3 [RenderAnimatedSize] Resume interrupted resizing animation on…
ff7c8b0 
… attach (flutter/flutter#100519)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
dc331d3 [RenderAnimatedSize] Resume interrupted resizing animation on…
de7e98d 
… attach (flutter/flutter#100519)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
dc331d3 [RenderAnimatedSize] Resume interrupted resizing animation on…
9f25dcf 
… attach (flutter/flutter#100519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LongCatIsLooong @goderbauer @fluttergithubbot