Prepare flutter_gallery for use_super_parameters
#100515
Conversation
flutter-dashboard
bot
added
a: animation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Gold has detected about 1 new digest(s) on patchset 1. |
goderbauer
force-pushed
the
super_params5
branch
2 times, most recently
from
8bf9be5 to
93c3581
Compare
|
test-exempt: code refactor with no semantic change |
goderbauer
force-pushed
the
super_params5
branch
from
93c3581 to
a7b33dc
Compare
| assert(sectionIndex >= 0 && sectionIndex < sections.length), | ||
| assert(selectedIndex.value! >= 0.0 && selectedIndex.value! < sections.length.toDouble()), | ||
| super(key: key, listenable: selectedIndex); | ||
| super(listenable: selectedIndex); |
There was a problem hiding this comment.
Oh this is interesting, if the names do not match you can't use the super shorthand... but listenable would not make sense as a parameter here.
| class _TappableWhileStatusIs extends StatefulWidget { | ||
| const _TappableWhileStatusIs( | ||
| this.status, { | ||
| Key? key, |
There was a problem hiding this comment.
I see some of these end up with no key instead of super.key. Why is that?
There was a problem hiding this comment.
These are private widgets and the key parameter is unused. The unused_element lint would trigger here if super.key were to be used.
There was a problem hiding this comment.
So clean! Lints are the future. 🤖
4 participants
#100575
Once all code in the repo has been migrated, we can turn on the
use_super_parameterslint.