Skip to content

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Mar 22, 2022

#100575

Excludes examples/api, see #100575 (comment).

@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 22, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer goderbauer changed the title Prepare examples for use_super_parameters Prepare examples (minus examples/api) for use_super_parameters Mar 28, 2022
@goderbauer goderbauer requested a review from gspencergoog March 28, 2022 23:09
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Nice! That's some super syntax!

@aam
Copy link
Member

aam commented Mar 30, 2022

this seems to have caused red dart-flutter hhh bot https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8818318172012638753/+/u/flutter_test_framework_coverage/stdout

27:55 +5519 ~13: loading /b/s/w/ir/cache/builder/flutter/packages/flutter/test/painting/continuous_rectangle_border_test.dart                                                                          
../../examples/layers/rendering/src/sector_layout.dart:623:34: Error: The argument type 'dynamic' can't be assigned to the parameter type 'HitTestResult'.
 - 'HitTestResult' is from 'package:flutter/src/gestures/hit_test.dart' ('lib/src/gestures/hit_test.dart').
  SectorHitTestResult.wrap(super.result) : super.wrap();
                                 ^
../../examples/layers/rendering/src/sector_layout.dart:635:41: Error: The argument type 'dynamic' can't be assigned to the parameter type 'HitTestTarget'.
 - 'HitTestTarget' is from 'package:flutter/src/gestures/hit_test.dart' ('lib/src/gestures/hit_test.dart').
  SectorHitTestEntry(RenderSector super.target, { required this.radius,  required this.theta })
                                        ^

@goderbauer
Copy link
Member Author

@aam looks like that bot is not running with the super parameter experiment enabled (available starting with SDK 2.17.0-0). I am not familiar with the bot, but somewhere you'll need to bump the lower SDK constrains to be at least 2.17.0-0.

/cc @mit-mit

@aam
Copy link
Member

aam commented Mar 30, 2022

current hypothesis is that it was caused by https://dart-review.googlesource.com/c/sdk/+/239081 that landed in dart sdk, has not reached flutter repo yet.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants