-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Prepare examples (minus examples/api) for use_super_parameters
#100514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ff329c1 to
c196ab4
Compare
c196ab4 to
73d975b
Compare
examples for use_super_parametersexamples (minus examples/api) for use_super_parameters
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
this seems to have caused red dart-flutter hhh bot https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8818318172012638753/+/u/flutter_test_framework_coverage/stdout |
|
current hypothesis is that it was caused by https://dart-review.googlesource.com/c/sdk/+/239081 that landed in dart sdk, has not reached flutter repo yet. |

#100575
Excludes
examples/api, see #100575 (comment).