Skip to content

Prepare flutter_tools for use_super_parameters #100509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goderbauer merged 1 commit into from
Mar 31, 2022
Merged

Prepare flutter_tools for use_super_parameters #100509

goderbauer merged 1 commit into from
Mar 31, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Mar 22, 2022 •
edited
Loading

Blocked on dart-lang/sdk#48708. Fixed.

#100575

Once all code in the repo has been migrated, we can turn on the use_super_parameters lint.

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 22, 2022
@goderbauer goderbauer force-pushed the super_param2 branch 2 times, most recently from 8a0dfb2 to 9f33870 Compare March 28, 2022 16:35
@goderbauer goderbauer mentioned this pull request Mar 28, 2022
Closed
16 tasks
@goderbauer goderbauer force-pushed the super_param2 branch 3 times, most recently from 5158070 to 4783063 Compare March 30, 2022 00:06
@mit-mit mit-mit mentioned this pull request Mar 30, 2022
Closed
@goderbauer goderbauer changed the title Prepare flutter_tools for use_super_parameters [BLOCKED] Prepare flutter_tools for use_super_parameters Mar 30, 2022
@goderbauer goderbauer changed the title [BLOCKED] Prepare flutter_tools for use_super_parameters Prepare flutter_tools for use_super_parameters Mar 31, 2022
christopherfujino
christopherfujino approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

packages/flutter_tools/lib/src/commands/analyze_continuously.dart
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:args/args.dart';
Copy link
Contributor

@christopherfujino christopherfujino Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it's great we got rid of all these imports!

@goderbauer goderbauer merged commit dcde816 into flutter:master Mar 31, 2022
@goderbauer goderbauer deleted the super_param2 branch March 31, 2022 18:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
6d8d0b7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
07b3702
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
dc8408d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 31, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
f78afd9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
78ed478
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 1, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
7b7aa12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
2049735
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
ef98cd2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
fce6fdb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
6129a05
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
f5d238b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 4, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
2030511
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
9887f87
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
d146212
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
444aaa6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
4d7cb88
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
dc6a283
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
b94cea9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
3e4a9c1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
b0c8901
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
2b25d41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
@engine-flutter-autoroll
dcde816 migrate to super params (flutter/flutter#100509)
f1d25bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goderbauer @christopherfujino