-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Expose ignoringPointer property for Draggable and LongPressDraggable
#100475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Gold has detected about 1 new digest(s) on patchset 1. |
|
Gold has detected about 1 new digest(s) on patchset 3. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #100475 at sha cdbb890fa2df9a166ae93331a957ab9e0a753ba8 |
|
Absolutely! Taking a look now, thanks for your patience. #98537 has been taking up my time lately. |
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thank you! Is it possible to add a test that uses MouseRegion like in the repro from the issue?
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @xu-baolin! 🎉
|
This pull request is not suitable for automatic merging in its current state.
|
|
@xu-baolin I restarted the google test to see if it passes now. |
Thanks, But the test still looks unhappy 😢 |
|
It's green now, but looks like there's a merge conflict. Can you resolve that? |
|
Can someone help check why the G test time out? Thanks :) |
|
@keyonghan is this another case where the Google testing should be ignored? For 2 weeks now it has not been successful for this PR, including after multiple rebases. |
|
From internal chat https://flutter-rob.corp.google.com/#/ has several issues, and it is okay to ignore google testing. /cc @CaseyHillers to confirm. |
|
@xu-baolin thanks for your patience, I can manually merge this once @CaseyHillers confirms. I can't manually set the check to green either due to the issues it is experiencing. |
|
Ack. Feel free to merge. |
…essDraggable` (flutter/flutter#100475)
…essDraggable` (flutter/flutter#100475)
hi, |

Fixes #92083
MU5735 R.I.P 🙏