Skip to content

Conversation

@xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented Mar 21, 2022

Fixes #92083

MU5735 R.I.P 🙏

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 21, 2022
@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/100475

@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/100475

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #100475 at sha cdbb890fa2df9a166ae93331a957ab9e0a753ba8

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 21, 2022
@xu-baolin
Copy link
Member Author

@Piinks hey, I see that you have reviewed #93733, which also to fix this issue, could you take a look at this? :)

@goderbauer goderbauer requested a review from Piinks March 23, 2022 21:38
@Piinks
Copy link
Contributor

Piinks commented Apr 5, 2022

Absolutely! Taking a look now, thanks for your patience. #98537 has been taking up my time lately.

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you! Is it possible to add a test that uses MouseRegion like in the repro from the issue?

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

Thank you @xu-baolin! 🎉

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer
Copy link
Member

@xu-baolin I restarted the google test to see if it passes now.

@xu-baolin
Copy link
Member Author

@xu-baolin I restarted the google test to see if it passes now.

Thanks, But the test still looks unhappy 😢

@goderbauer
Copy link
Member

It's green now, but looks like there's a merge conflict. Can you resolve that?

@xu-baolin
Copy link
Member Author

Can someone help check why the G test time out? Thanks :)

@Piinks
Copy link
Contributor

Piinks commented Apr 19, 2022

@keyonghan is this another case where the Google testing should be ignored? For 2 weeks now it has not been successful for this PR, including after multiple rebases.
Related issue: #101719

@keyonghan
Copy link
Contributor

From internal chat https://flutter-rob.corp.google.com/#/ has several issues, and it is okay to ignore google testing. /cc @CaseyHillers to confirm.

@Piinks
Copy link
Contributor

Piinks commented Apr 19, 2022

@xu-baolin thanks for your patience, I can manually merge this once @CaseyHillers confirms. I can't manually set the check to green either due to the issues it is experiencing.

@CaseyHillers
Copy link
Contributor

Ack. Feel free to merge.

@iilic89
Copy link

iilic89 commented Aug 2, 2023

Fixes #92083

MU5735 R.I.P 🙏

hi,
after implementing ignoring Pointer: false, everything works good except i am not able to scroll SingleChildScrollView. Some advice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MouseRegion's cursor in a Draggable's feedback does not work

8 participants