Skip to content

Add Gradle Kotlin DSL support (#93238) #100442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexugthub wants to merge 4 commits into from
Closed

Add Gradle Kotlin DSL support (#93238) #100442

alexugthub wants to merge 4 commits into from

Conversation

@alexugthub
Copy link

@alexugthub alexugthub commented Mar 20, 2022 •
edited
Loading

These changes are in relation with a request from those who want to migrate from Groovy to Kotlin DSL. This can open the possibility to either allow developers to choose the DSL for Android projects or to have that as an implicit build setup.

This request is presented here #93238 and I tried to do my best to fulfil it,

It's just a few changes in flutter_tools and now I can build with both .gradle and .gradle.kts for Android.

Open to any suggestions or improvements

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 20, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 20, 2022
@google-cla
Copy link

google-cla bot commented Mar 20, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@skia-gold
Copy link

skia-gold commented Mar 20, 2022

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/100442

@skia-gold
Copy link

skia-gold commented Mar 21, 2022

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/100442

@christopherfujino
Copy link
Contributor

christopherfujino commented Mar 24, 2022

@AlexMro thanks for contributing! There are two things I would need before reviewing this PR:

  1. fix existing tests that were broken by your change
  2. add new tests, verifying the new feature (namely support for kotlin DSL)

Thanks!

@christopherfujino christopherfujino added waiting for tree to go green waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds and removed waiting for tree to go green labels Mar 24, 2022
@blasten blasten added the platform-android Android applications specifically label Apr 12, 2022
@christopherfujino
Copy link
Contributor

christopherfujino commented Apr 21, 2022

Thank you for contributing! As you have not responded within 3 weeks, I will be closing this PR as stale. If you are still interested in landing this, feel free to rebase this PR upstream, address code review feedback, and re-open this PR.

@interacsion
Copy link

interacsion commented Sep 18, 2022

It seems that this isn't solved yet, could I take over and make my own PR?

@bartekpacia bartekpacia mentioned this pull request Dec 30, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexugthub @skia-gold @christopherfujino @interacsion @blasten