-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Specify destination when building for macOS #100315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I don't imagine this will be compatible with #100271 |
|
We could probably make this a little more robust by invoking |
|
@christopherfujino I'll try patching that in with this one and seeing what happens, but again I only have an x64 mac to test on right now :) |
|
This patch still works with that - @cbracken's patch is about the binary we build, this patch is about specifying what destination to run the application on. However, this patch probably has problems on arm64 macs. |
|
Based on local testing I don't need the target arch specifier and Xcode still won't complain. |
|
Verified manually after landing #100271 and this lgtm (again). |
|
This appears now to be a problem for arm64 (m1) Macs: although it is just a warning and the app does launch, the last 2 lines are in red, which suggests that this is an error, when it really isn't. But this fixes it - but make sure you only use this for Debug mode and not All: #86590 (comment) |
Tracking that issue in #86590 |

Fixes #86590
I do not have access to an arm64 mac to test that this still works. It will probably need to be modified a bit for that use case when we support building arm64 binaries.