Skip to content

Conversation

@TahaTesser
Copy link
Member

part of #100180

Code Sample

minimal code sample
import 'package:flutter/material.dart';
import 'package:flutter/cupertino.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    Duration duration = const Duration(hours: 1, minutes: 23);

    return MaterialApp(
      title: 'CupertinoTimerPicker (MaterialApp)',
      theme: ThemeData(brightness: Brightness.dark),
      home: Scaffold(
        body: Center(
          child: SizedBox(
            height: 250,
            child: CupertinoTimerPicker(
              mode: CupertinoTimerPickerMode.hm,
              initialTimerDuration: duration,
              onTimerDurationChanged: (Duration newDuration) {},
            ),
          ),
        ),
      ),
    );
  }
}
Issue Fix

Similar to:

color: CupertinoDynamicColor.resolve(CupertinoColors.label, context),

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Mar 17, 2022
@TahaTesser TahaTesser changed the title Fix CupertinoTimerPickerdark mode text color Fix CupertinoTimerPicker dark mode text color Mar 17, 2022
@guidezpl
Copy link
Member

guidezpl commented May 2, 2022

Please address merge conflicts

@TahaTesser TahaTesser force-pushed the fix_timer_picker_text_color branch 2 times, most recently from e13a827 to c529187 Compare May 3, 2022 06:16
@TahaTesser TahaTesser force-pushed the fix_timer_picker_text_color branch from c529187 to baa8476 Compare May 3, 2022 14:33
@fluttergithubbot fluttergithubbot merged commit adb8b60 into flutter:master May 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2022
@TahaTesser TahaTesser deleted the fix_timer_picker_text_color branch May 3, 2022 16:55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 3, 2022
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants