Skip to content

Revert "[framework] don't hit test for system nav bar or system chrome on desktop" #100263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 17, 2022
Merged

Revert "[framework] don't hit test for system nav bar or system chrome on desktop" #100263

fluttergithubbot merged 1 commit into from
Mar 17, 2022

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 17, 2022

Reverts #97883

We're missing integration tests for this functionality

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Mar 17, 2022
@jonahwilliams jonahwilliams mentioned this pull request Mar 17, 2022
Closed
Piinks
Piinks approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

goderbauer
goderbauer approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 984d8a8 into master Mar 17, 2022
@fluttergithubbot fluttergithubbot deleted the revert-97883-benchy_mc_benchface_2 branch March 17, 2022 23:55
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 18, 2022
@engine-flutter-autoroll
984d8a8 Revert "[framework] don't hit test for system nav bar or syst…
a1313ed 
…em chrome on desktop" (flutter/flutter#100263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2022
@engine-flutter-autoroll
984d8a8 Revert "[framework] don't hit test for system nav bar or syst…
1633ecd 
…em chrome on desktop" (flutter/flutter#100263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 18, 2022
@engine-flutter-autoroll
984d8a8 Revert "[framework] don't hit test for system nav bar or syst…
e57be26 
…em chrome on desktop" (flutter/flutter#100263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 18, 2022
@engine-flutter-autoroll
984d8a8 Revert "[framework] don't hit test for system nav bar or syst…
b399b6f 
…em chrome on desktop" (flutter/flutter#100263)
@camsim99 camsim99 mentioned this pull request Mar 21, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @goderbauer @Piinks @fluttergithubbot