Skip to content

Frame build time regression in flutter_gallery_ios__transition_perf #99249

@zanderso

Description

@zanderso

SkiaPerf is reporting regressions in average and 90th %-ile framebuild times in this benchmark:

https://flutter-flutter-perf.skia.org/e/?begin=1642956908&end=1645923376&keys=X92ead8c5190b5e262a415353fe431d08&requestType=0&xbaroffset=27665

The regression is reported on the Engine roll #98940, however there is no data for the previous two framework commits:

#98542 and #93439, however they don't look too suspicious to me.

It looks like the worst frame time has actually doubled, which is why the average is going up a lot more than the 90th %-ile:

https://flutter-flutter-perf.skia.org/e/?begin=1642789126&end=1645923376&queries=test%3Dflutter_gallery_ios__transition_perf&requestType=0

The Engine roll has mainly Dart and Skia rolls. I'm going to speculate that this is also related to recent SkParagraph changes and cc @jason-simmons.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Critical issues such as a build break or regressionc: performanceRelates to speed or footprint issues (see "perf:" labels)engineflutter/engine related. See also e: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions