Skip to content

Framework's matchesGoldenFile should assert that file name has right structure #98943

@goderbauer

Description

@goderbauer

#98772 broke the tree because the file name provided to matchesGoldenFile was missing .png. We should assert that file names have the right structure - maybe even that they are unique at least for the given file?

incorrect:

matchesGoldenFile('slider_start_text_scale_1_width_0'),

correct:

matchesGoldenFile('slider_start_text_scale_1_width_0.png'),

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passframeworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions