-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.
Description
We currently have a variety of functions named Utf8ToUtf16, Utf16FromUtf8, StringToWideString in various places throughout the codebase. Now that FML can be used in the platform-specific desktop embedders, move string-encoding functionality to FML and use that.
Windows APIs use wchar_t-based strings and as a result, we'll need to continue to keep Windows-specific functions in fml/platform/win/wstring_conversion.h. This does, however let us reduce our use of _SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING to a single instance.
Related: #50053
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.