-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: internationalizationSupporting other languages or locales. (aka i18n)Supporting other languages or locales. (aka i18n)r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versiontoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.
Description
Steps to Reproduce
- Run
flutter gen-l10n --help. - See the help of
--[no-]nullable-getter.
Expected results:
"If this value is set to false"
Actual results:
"If this value is set to true"
If this value is set to true,
then a null check is performed on the returned value of
Localizations.of(context), removing the need for null
checking in user code.
Additional context
A PR (#90180) by someone else to fix this has been closed without being merged because of a missing test.
I gave up fixing it myself, not knowing what test was needed, but I thought I should at least file an issue about it so that it'd catch someone's eye.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: internationalizationSupporting other languages or locales. (aka i18n)Supporting other languages or locales. (aka i18n)r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versiontoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.