Skip to content

[flutter_tools] FLUTTER_TOOL_ARGS should be part of prebuilt tool snapshot's stamp file #94892

New issue
New issue
Closed
Closed
[flutter_tools] FLUTTER_TOOL_ARGS should be part of prebuilt tool snapshot's stamp file#94892
Assignees
Hixie
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.toolAffects the "flutter" command-line tool. See also t: labels.waiting for PR to land (fixed)A fix is in flight

Description

@christopherfujino
christopherfujino
opened on Dec 8, 2021

See the discussion here for more context.

Basically, we should invalidate the pre-built flutter CLI tool snapshot if the FLUTTER_TOOL_ARGS env variable changes. If we add these flags to the //flutter/bin/cache/flutter_tools.stamp file (which currently only contains the framework git revision), changing the flags will cause the bash script to re-build the flutter tool with the new args.

Activity

  1. danagbemava-nc
    added
    in triagePresently being triaged by the triage team
    passed first triage
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    toolAffects the "flutter" command-line tool. See also t: labels.
    and removed
    in triagePresently being triaged by the triage team
    on Dec 9, 2021
  2. Hixie
    self-assigned this
    on Dec 9, 2021

  3. Hixie commented on Dec 9, 2021

    @Hixie
    Hixie
    on Dec 9, 2021
    Contributor

    Fixed in #94951

  4. Hixie
    added
    waiting for PR to land (fixed)A fix is in flight
    on Dec 9, 2021
  5. Hixie
    closed this as completedon Mar 16, 2023

  6. github-actions commented on Mar 30, 2023

    @github-actions
    github-actionsBot
    on Mar 30, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. github-actions
    locked as resolved and limited conversation to collaborators on Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: contributor-productivityTeam-specific productivity, code health, technical debt.toolAffects the "flutter" command-line tool. See also t: labels.waiting for PR to land (fixed)A fix is in flight

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions