Skip to content

Deprecate PhysicalModelLayer/PhysicalShapeLayer #91852

@dnfield

Description

@dnfield

@flar @goderbauer fyi

Historically, Fuchsia wanted these to be layers so that it could do its own implementation of shadow rendering. That is no longer the case, and now we have no platforms that need to do the shadow rendering. Having these as separate layers may confuse cacheability and requires engine-side implementation for drawing shadows that could be handled in the framework instead.

For a start, we could simply stop using those layers in RenderPhysicalModel and RenderPhysicalShape, basically reverting some of the code in #29701. That change was made to help make more consistency across platforms and support some Fuchsia specific debugging code that has since been reverted separately.

We'd then want to deprecate the framework classes and the scene builder API, and remove them from the engine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listengineflutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions