-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: desktopRunning on desktopRunning on desktopa: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: disabled testTracks the restoration of a disabled testTracks the restoration of a disabled testc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.platform-windowsBuilding on or for Windows specificallyBuilding on or for Windows specifically
Description
In order to enable all the currently-passing Windows UWP unit tests and prevent any regressions, I've disabled currently-failing tests and am enabling these unit tests as part of presubmit.
The failures fall into the following categories:
- threading issues (accessing an object from the wrong thread)
- filesystem sandboxing issues (trying to access a path outside the sandbox)
- network issues (trying to connect to sandboxed vm service)
We should fix and re-enable these. Known tests at time of filing:
ShellTest.DisallowedDartVMFlagShellTest.AllowedDartVMFlagShellTest.OnPlatformViewDestroyDisablesThreadMergerShellTest.WaitForFirstFrameShellTest.WaitForFirstFrameMultipleShellTest.WaitForFirstFrameInlinedShellTest.OnServiceProtocolGetSkSLsWorksShellTest.OnServiceProtocolSetAssetBundlePathWorksShellTest.AssetManagerSingleShellTest.AssetManagerMultiPersistentCacheTest.CacheSkSLWorksPersistentCacheTest.CanLoadSkSLsFromAssetPersistentCacheTest.CanRemoveOldPersistentCachePersistentCacheTest.CanPurgePersistentCachePersistentCacheTest.PurgeAllowsFutureSkSLCache
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: desktopRunning on desktopRunning on desktopa: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: disabled testTracks the restoration of a disabled testTracks the restoration of a disabled testc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.platform-windowsBuilding on or for Windows specificallyBuilding on or for Windows specifically